[nfc] enabling asan leak sanitizer #2187
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
use KJ_CLEAN_SHUTDOWN to give it a chance to run
|
@jasnell I have disabled the test as discussed |
jasnell
approved these changes
May 29, 2024
| @@ -170,6 +170,8 @@ wd_cc_library( | |||
| exclude = [ | |||
| # defined below | |||
| "macro-meta-test.c++", | |||
| # TODO(jasnell) modules-new-test is leaking IsolateModuleRegistry and fails asan leak detector | |||
| "modules-new-test.c++", | |||
There was a problem hiding this comment.
For others reviewing, the modules-new-test is currently the only thing using IsolateModuleRegistry while the new implementation is still being developed. Disabling the test is safe and I'll be revisiting this as I continue work on the new module registry implementation.
fhanau
approved these changes
May 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
use KJ_CLEAN_SHUTDOWN to give it a chance to run